Skip to content

Allow adding a paragraph at the end of a ScriptureDeltaDocument#56

Merged
pmachapman merged 1 commit intomainfrom
fix_range_error
Jan 27, 2026
Merged

Allow adding a paragraph at the end of a ScriptureDeltaDocument#56
pmachapman merged 1 commit intomainfrom
fix_range_error

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Jan 27, 2026

Fixes #55


This change is Reviewable

@pmachapman pmachapman requested a review from ddaspit January 27, 2026 20:28
@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2026

🦋 Changeset detected

Latest commit: 8d7d323

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sillsdev/lynx-delta Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pmachapman pmachapman force-pushed the fix_range_error branch 2 times, most recently from 657bb29 to 914ae95 Compare January 27, 2026 20:36
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. You just need to add a changeset. We use a tool called Changesets to manage versioning for the Lynx monorepo. Here are the instructions to add a changeset. To add a changeset, you run npx changeset.

@ddaspit reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman).

Copy link
Collaborator Author

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit Done - thank you!

@pmachapman made 1 comment.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @ddaspit).

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman).

@pmachapman pmachapman merged commit 6cd0ef5 into main Jan 27, 2026
2 checks passed
@pmachapman pmachapman deleted the fix_range_error branch January 27, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash: Cannot read properties of undefined (reading 'range')

2 participants