Conversation
🦋 Changeset detectedLatest commit: 6789475 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 20 of 20 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @benjaminking)
ddaspit
force-pushed
the
quote_continuers
branch
from
8573a7a to
97baaee
Compare
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
@benjaminking I forgot about this PR. I was trying to get it in, but it seems to be failing a unit test.
@ddaspit made 1 comment.
Reviewable status:
|
It looks like the delta document changes caused one of the test outputs to change. I've updated that test now. |
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 1 file and all commit messages.
Reviewable status:
2 participants
This PR adds support for quote continuers into Lynx. Quote continuers are used when continuing a quote across multiple paragraphs. In English, the quote is not terminated at the end of the first paragraph, but a new opening quotation mark is used at the start of the second paragraph.
This also adds a new type of warning that can be produced for incorrectly formatted quote continuers, specifically when a first-level quote continuer is present, but a subsequent continuer is not, in a situation where nested quotes are being carried across multiple paragraphs. There is also a quick fix provided to correct this error.
This resolves #31
This change is