Skip to content

Fix Svelte 5 ownership and state_proxy_equality_mismatch warnings#2199

Merged
myieye merged 3 commits intodevelopfrom
claude/fix-entry-editor-bindings-A4ZFF
Mar 10, 2026
Merged

Fix Svelte 5 ownership and state_proxy_equality_mismatch warnings#2199
myieye merged 3 commits intodevelopfrom
claude/fix-entry-editor-bindings-A4ZFF

Conversation

@myieye
Copy link
Collaborator

@myieye myieye commented Mar 10, 2026

  • Remove redundant === check in StompGuard watch callback that triggered \state_proxy_equality_mismatch\ warning (the check was just an optimization, not a correctness requirement)
  • Use bind:entry to establish proper ownership for EntryEditor and prevent warnings.

@github-actions github-actions bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Mar 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

UI unit Tests

  1 files  ±0   54 suites  ±0   25s ⏱️ ±0s
140 tests ±0  140 ✅ ±0  0 💤 ±0  0 ❌ ±0 
207 runs  ±0  207 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4c7e50a. ± Comparison against base commit 3f62d45.

♻️ This comment has been updated with latest results.

@argos-ci
Copy link

argos-ci bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Mar 10, 2026, 1:21 PM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

C# Unit Tests

162 tests  ±0   162 ✅ ±0   19s ⏱️ -1s
 23 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 4c7e50a. ± Comparison against base commit 3f62d45.

♻️ This comment has been updated with latest results.

@myieye myieye force-pushed the claude/fix-entry-editor-bindings-A4ZFF branch from 4f34407 to 50d3ca9 Compare March 10, 2026 13:09
@myieye myieye force-pushed the claude/fix-entry-editor-bindings-A4ZFF branch from 50d3ca9 to 489e23b Compare March 10, 2026 13:13
@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ec3142a0-b941-4e25-93d2-86975e779be0

📥 Commits

Reviewing files that changed from the base of the PR and between 3f62d45 and 4c7e50a.

📒 Files selected for processing (3)
  • frontend/viewer/src/lib/components/stomp/stomp-guard.svelte.ts
  • frontend/viewer/src/lib/entry-editor/EditEntryDialog.svelte
  • frontend/viewer/src/project/browse/EntryView.svelte

📝 Walkthrough

Walkthrough

This pull request modifies three files to implement two-way data binding for entry values across components and removes an early-return optimization from the stomp-guard watch callback. The changes convert entry propagation from static props to bound references, enabling synchronization between parent and child components.

Changes

Cohort / File(s) Summary
Entry Component Binding
frontend/viewer/src/lib/entry-editor/EditEntryDialog.svelte, frontend/viewer/src/project/browse/EntryView.svelte
Converted from passing entry as a static prop to two-way binding (bind:entry). EntryView also changed entry variable from const to let to support mutability required for binding.
Stomp Guard Watch Callback
frontend/viewer/src/lib/components/stomp/stomp-guard.svelte.ts
Removed early-return optimization that bypassed processing when newParentValue equals current _value, allowing the callback to always execute subsequent logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • hahn-kev
  • imnasnainaec

Poem

🐰 Two-way bindings dance and sway,
From parent down to child's display,
No more one-way static paths—
The stomp-guard optimization hath
Been trimmed to let the flow run true! 🎉

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/fix-entry-editor-bindings-A4ZFF

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@myieye myieye marked this pull request as ready for review March 10, 2026 14:37
@myieye myieye merged commit 63ba63e into develop Mar 10, 2026
26 of 27 checks passed
@myieye myieye deleted the claude/fix-entry-editor-bindings-A4ZFF branch March 10, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant