Fix Svelte 5 ownership and state_proxy_equality_mismatch warnings#2199
Fix Svelte 5 ownership and state_proxy_equality_mismatch warnings#2199
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019cd7c5-4555-7639-b176-ab2589c4cc66 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
4f34407 to
50d3ca9
Compare
…EntryDialog Amp-Thread-ID: https://ampcode.com/threads/T-019cd7c5-4555-7639-b176-ab2589c4cc66 Co-authored-by: Amp <amp@ampcode.com>
50d3ca9 to
489e23b
Compare
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis pull request modifies three files to implement two-way data binding for entry values across components and removes an early-return optimization from the stomp-guard watch callback. The changes convert entry propagation from static props to bound references, enabling synchronization between parent and child components. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bind:entryto establish proper ownership for EntryEditor and prevent warnings.