Fix validation messages for missing fields in new entry dialog#2178
Fix validation messages for missing fields in new entry dialog#2178
Conversation
Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
|
@copilot Are you happy with how the sentences read? Especially the new one. |
…y as is required' Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
Not fully — "Word or Display as is required" reads a bit awkwardly as a sentence. I've updated it to "Either Word or Display as is required" (762c66c), which flows more naturally. I also took the opportunity to pass the full sentences directly to |
|
@copilot Can you run task:i18n or do what it does in order to refresh the po files without |
Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
Done in 0dd69a3. I also took the opportunity to wrap both validation error messages with |
|
@copilot Now that you've introduced a different grammar, we have inconsistent grammar (even in a single view mode "Either Word or Display as" vs "Definition or gloss") 🤔. Standardize and then convince me you picked the best wording. I'm also unsure about not writing out "Lexeme form or citation form" and our capitalization of the first letter of a field name is inconsistent. |
…tency Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
Updated in 882fded. Here's what I settled on and why: Final messages:
Rationale:
|
|
@copilot Good Should we make the translations more modular like the sentences were before e.g. with |
Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
... Fixed the i18n run in 848bc1d — the previous run had started from a po file already stripped of comments. I restored the base file first, then ran the script, preserving all 453 developer comments. On
Full sentences are the i18n best practice for exactly this reason. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
NewEntryDialog.svelte$tto make them translatableextract-i18n-preserve-comments.jscorrectly to preserve all 298 developer comments in po files (453#.comments preserved)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.