Conversation
There was a problem hiding this comment.
Pull request overview
Updates delete-recording button enable/disable logic in PassageDetailItem to prevent delete actions when there’s no current segment media available.
Changes:
- Disabled the recorder delete button when
currentSegmentMediaIdis not set. - Disabled the admin “delete recording” button in the playback row when
currentSegmentMediaIdis not set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/renderer/src/components/PassageDetail/PassageDetailItem.tsx
Outdated
Show resolved
Hide resolved
gtryus
force-pushed
the
feature/TT-7101-pbt-delete-availability
branch
from
91a0196 to
60af64a
Compare
…urrentSegmentMediaId check - Modified the delete recording button to be disabled when currentSegmentMediaId is not set, ensuring better control over button availability. - Updated the corresponding button in the handleDelete function to maintain consistent behavior.
gtryus
force-pushed
the
feature/TT-7101-pbt-delete-availability
branch
from
60af64a to
29281b4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| recorderControlsRef.current?.deleteRecording(); | ||
| }} | ||
| disabled={isRecording() || playing} | ||
| disabled={isRecording() || playing || !currentSegmentMediaId} |
There was a problem hiding this comment.
The PR description states "Updated the corresponding button in the handleDelete function to maintain consistent behavior," but the diff only shows changes to one delete button (the one that calls deleteRecording). The admin delete button at line 1091-1096 that calls handleDelete(playItem) does not appear to have any changes in this PR. Please clarify if additional changes were intended or update the PR description to accurately reflect the changes made.
1 participant
Uh oh!
There was an error while loading. Please reload this page.