TT-6815 update workflow status component by gtryus · Pull Request #204 · sillsdev/apm

gtryus · 2026-02-11T01:03:35Z

Introduced new translation units for workflow step tips in both XLIFF and XLF files.
Updated the MobileWorkflowSteps component to display tips for current steps in a dialog.
Enhanced the state management for workflow steps to include completed step tracking.
Added new string keys for tips in the localization model and reducers.
remove unused WorkflowStepsMobile component

Copilot

Pull request overview

Updates the mobile workflow status UI to show per-step tips (localized) and to visually distinguish completed steps, while adding the necessary localization keys and translation units.

Changes:

Added new workflowSteps.*Tip string keys to the localization model and default English strings.
Enhanced MobileWorkflowSteps to show a tip dialog for the current step and to render different colors for current/completed/incomplete steps.
Added translation units for the new tip strings in both .xlf and .xliff, and removed the unused WorkflowStepsMobile component and its Cypress test.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
src/renderer/src/store/localization/reducers.tsx	Adds English default strings for the new workflow-step tip keys.
src/renderer/src/store/localization/model.tsx	Extends `IWorkflowStepsStrings` with the new `*Tip` keys.
src/renderer/src/store/localization/exported-strings-name.json	Updates exported strings bundle reference.
src/renderer/src/components/PassageDetail/mobile/WorkflowStepsMobile.tsx	Removes unused mobile wrapper component.
src/renderer/src/components/PassageDetail/mobile/WorkflowStepsMobile.cy.tsx	Removes Cypress coverage for the removed component.
src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx	Adds completed-step coloring and a localized tip dialog for the current step.
src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.cy.tsx	Adds Cypress coverage for new coloring and tip dialog behavior.
localization/TranscriberAdmin-en.xlf	Adds translation units for the new workflow-step tip strings.
localization/TranscriberAdmin-en-1.2.xliff	Adds translation units for the new workflow-step tip strings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

localization/TranscriberAdmin-en.xlf

localization/TranscriberAdmin-en-1.2.xliff

src/renderer/src/store/localization/reducers.tsx

localization/TranscriberAdmin-en.xlf

localization/TranscriberAdmin-en-1.2.xliff

src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx

src/renderer/src/store/localization/reducers.tsx

localization/TranscriberAdmin-en-1.2.xliff

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx:73

The old WorkflowStepsMobile component supported pagination for workflow steps when there were too many to display at once (using firstStepIndex and next/prev buttons). The new MobileWorkflowSteps component sets overflowX to 'hidden' which means workflow steps that don't fit on screen will be hidden with no way to access them. Consider either adding pagination back or changing overflowX to 'auto' or 'scroll' to allow horizontal scrolling.

      <Box
        sx={{
          display: 'flex',
          justifyContent: 'center',
          gap: 0.75,
          overflowX: 'hidden',

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx

Copilot · 2026-02-11T17:08:16Z

src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx

        </Typography>
      )}
+      <Dialog open={tipOpen} onClose={() => setTipOpen(false)}>
+        <DialogTitle>{getWfLabel(currentLabel ?? '')}</DialogTitle>


The null coalescing operator is unnecessary here since currentLabel is already checked to be truthy in the parent conditional at line 109. This can be simplified to just getWfLabel(currentLabel).

src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx

src/renderer/src/store/localization/reducers.tsx

localization/TranscriberAdmin-en.xlf

localization/TranscriberAdmin-en-1.2.xliff

- Introduced new translation units for workflow step tips in both XLIFF and XLF files. - Updated the MobileWorkflowSteps component to display tips for current steps in a dialog. - Enhanced the state management for workflow steps to include completed step tracking. - Added new string keys for tips in the localization model and reducers. - remove unused WorkflowStepsMobile component

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx

Copilot · 2026-02-11T17:55:20Z

src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx

+            <ButtonBase
              key={step.id}
              data-cy="workflow-step"
+              role="button"


The step indicator buttons are focusable/clickable but have no accessible name (no text, no aria-label). Add an aria-label (e.g., derived from getWfLabel(step.label)) so screen readers can announce what each step button represents.

Suggested change

role="button"

role="button"

aria-label={getWfLabel(step.label)}

This is way more information given to the user of the mobile app so I don't think this is appropriate.

…wSteps.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

gtryus requested a review from Copilot February 11, 2026 01:05

Copilot started reviewing on behalf of gtryus February 11, 2026 01:06 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

gtryus force-pushed the feature/TT-6815-mobile-workflow-status branch 2 times, most recently from e3d00d7 to 753fdeb Compare February 11, 2026 01:26

gtryus requested review from Copilot and sarahentzel February 11, 2026 01:44

Copilot started reviewing on behalf of gtryus February 11, 2026 01:44 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx Outdated Show resolved Hide resolved

src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx Show resolved Hide resolved

gtryus force-pushed the feature/TT-6815-mobile-workflow-status branch from 753fdeb to ca29981 Compare February 11, 2026 16:59

gtryus requested a review from Copilot February 11, 2026 17:01

Copilot started reviewing on behalf of gtryus February 11, 2026 17:01 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

gtryus force-pushed the feature/TT-6815-mobile-workflow-status branch from ca29981 to 4148a01 Compare February 11, 2026 17:50

gtryus requested a review from Copilot February 11, 2026 17:51

Copilot started reviewing on behalf of gtryus February 11, 2026 17:52 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

Update src/renderer/src/components/PassageDetail/mobile/MobileWorkflo…

1cbb184

…wSteps.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

gtryus merged commit 03404ee into develop Feb 11, 2026
1 check passed

gtryus deleted the feature/TT-6815-mobile-workflow-status branch February 11, 2026 19:07

	role="button"
	role="button"
	aria-label={getWfLabel(step.label)}

Uh oh!

Conversation

gtryus commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

gtryus Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant