Conversation
Change-Id: Ibef14ab3860dee9e93b739664ea7d650cd6d0587
papeh
approved these changes
Feb 20, 2026
| @@ -0,0 +1,60 @@ | |||
| mengajar | |||
Contributor
There was a problem hiding this comment.
Should the test data go under the test project?
Collaborator
Author
There was a problem hiding this comment.
Well, there are two test projects, both of which use the same test data. That's why the test data are at a higher level...
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <configuration> | |||
| <package id="Newtonsoft.Json" version="12.0.3" targetFramework="net461" /> | |||
Contributor
There was a problem hiding this comment.
should be 13.0.4 (although that will be moot after we move the package references into the CSProj files and pull the versions from Directory.Packages.props in the repo root)
Contributor
There was a problem hiding this comment.
some or all of these could be merged into the root .gitignore
Contributor
There was a problem hiding this comment.
Should the original readme be brought over, too?
Collaborator
Author
There was a problem hiding this comment.
Yes, that's reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for LT-22417 (Move HCSynthByGlass into FLEx repo).
HCSynthByGloss contains three products that have been in production use by FLExTrans for some time now. The changes here moved what was in the GitHub repository at https://github.com/sillsdev/HCSynthByGloss to Src\Utilities. The products are:
HCsynthByGlossLib.dll contains common classes used by all three.
The HCSynthByGloss tools use two XSLT transforms that I added to Src\Transforms\Presentation. In order for these to be included in the ApplicationTransforms.dll, I added them to Build\Windows.targets.
There also is a ReadMe.txt file pointing to the soon-to-be-archived repository mentioned above in case some one needs to check its history.
Note that the code in that repository that is now in FLEx has never undergone a code review. Having said that, since it is in production use, I'm not expecting anyone to review every line in it.
This change is