Repository navigation
Fall back to IP-only majority with local discovery port - #316
Open
NikhilSharmaWe wants to merge 1 commit into
Open
NikhilSharmaWe wants to merge 1 commit into
NikhilSharmaWe wants to merge 1 commit into
Conversation
Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #292, competing UDP ports for the same public IP produce no ENR update. That is correct when the voted ports are ephemeral and unreachable, but it also leaves nodes with a stable public IP and a forwarded listen port without any advertised address (see sigp/lighthouse#10172).
Prefer a clear IP:port majority as today. If ports disagree but the IP has a clear majority, advertise that IP with the local ENR UDP port, else the listen port.
Test plan
cargo test --libcargo clippy --lib -- -D warnings