[#6267] Remove decorative image from groups memberships label in conversation header and labels for Voice Over#6268
Closed
pylapp wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Note @sashaweiss-signal This pull request is ready for review :-) |
…ation header (signalapp#6267) In a conversation with one people, user can have a label saying there is not group in common between user and the people. However the image, a decorative one, is vocalized, likle "attachment png". Now this image is removed for Voice Over. Signed-off-by: Pierre-Yves Lapersonne <dev@pylapersonne.info>
…t view (signalapp#6267) With attributed string, the image in labels of sheet with details of users I talk with is vocalized like "attachment png". The image is decorative and should not be vocalzied by Voice Over. Now fixed. Signed-off-by: Pierre-Yves Lapersonne <dev@pylapersonne.info>
pylapp
force-pushed
the
pr/6267-fix-decorative-image-vocalized-in-label
branch
from
d1e532e to
3765b1e
Compare
pylapp
changed the title
Voice OverVoice Over
Contributor
|
This merged internally as 7771cf1, which will be available with our next release! Thanks again for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
Remove decorative image from groups memberships label in conversation header
Commit fb41b29
In a conversation with one people, user can have a label saying there is not group in common between user and the people.
However the image, a decorative one, is vocalized, likle "attachment png".
Now this image is removed for Voice Over.
Vocalization of decorative imaged in about sheet of user in tchat view
Commit 3765b1e
With attributed string, the image in labels of sheet with details of users I talk with
is vocalized like "attachment png". The image is decorative and should not be
vocalzied by Voice Over.
Now fixed.
Related issue
Closes #6267