Draft
Conversation
- extract shared dummy triple/presignature helpers - move triple insertion/assert helper usage into shared module - move participants test helper into shared helpers
volovyks
commented
Feb 26, 2026
| use crate::node_client::Options as NodeClientOptions; | ||
|
|
||
| #[tokio::test] | ||
| async fn test_broadcast_sync_on_empty_update() { |
Contributor
Author
There was a problem hiding this comment.
This logic was unclear to me. When the owner sends an empty update, it means they no longer hold any Ts or Ps, and other nodes need to clean up their storage accordingly. This situation can occur if someone drops their storage or uses all of their owned Ts or Ps.
Contributor
Author
There was a problem hiding this comment.
@ChaoticTempest is that an attempt to handle storage errors? fetch_owned returns a Vec no matter what:
pub async fn fetch_owned(&self, me: Participant) -> Vec<A::Id>
Contributor
Author
There was a problem hiding this comment.
Now fetch_owned returns a Result<>
volovyks
commented
Feb 26, 2026
volovyks
commented
Feb 26, 2026
| .insert(dummy_pair(id), node) | ||
| .await; | ||
| #[test_log::test(tokio::test)] | ||
| async fn test_state_sync_e2e() { |
Contributor
Author
There was a problem hiding this comment.
For now, I'm using a simple Integration test for State sync. I may work on the component layer implementation later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.