Skip to content

Allow credentials to be passed up to allow securing behind phoenix pipelines - #47

Open
mgwidmann wants to merge 1 commit into
shinyscorpion:masterfrom
mgwidmann:include_credentials
Open

Allow credentials to be passed up to allow securing behind phoenix pipelines#47
mgwidmann wants to merge 1 commit into
shinyscorpion:masterfrom
mgwidmann:include_credentials

Conversation

@mgwidmann

Copy link
Copy Markdown

The following does not work:

scope "/admin" do
  pipe_through :admin

  forward "/wobserver", Wobserver.Web.Router
end

All JSON api requests end up being denied because no cookies are sent and so therefore cannot be validated.

@coveralls

coveralls commented Sep 20, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.716% when pulling 5d69ac6 on mgwidmann:include_credentials into 7c6186b on shinyscorpion:master.

@mgwidmann

Copy link
Copy Markdown
Author

I'm not sure that my changes actually caused those errors, did they?

@mgwidmann

Copy link
Copy Markdown
Author

bump any thoughts on this? Its quite annoying to build this from source every time...

@mgwidmann

Copy link
Copy Markdown
Author

can we get some movement on this PR?

@langalex

langalex commented Jan 5, 2018

Copy link
Copy Markdown

looking at master, the build was already broken, so it wasn't you @mgwidmann.

@langalex

langalex commented Jan 5, 2018

Copy link
Copy Markdown

most of the breakage occurred with this "Update dependencies." commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants