enable HAVE_FREETYPE when freetype feature is set#259
Open
narodnik wants to merge 1 commit intoservo:mainfrom
Open
enable HAVE_FREETYPE when freetype feature is set#259narodnik wants to merge 1 commit intoservo:mainfrom
narodnik wants to merge 1 commit intoservo:mainfrom
Conversation
mrobinson
reviewed
Jun 24, 2024
Comment on lines
+4
to
+6
| [submodule "harfbuzz-sys/freetype-sys"] | ||
| path = harfbuzz-sys/freetype-sys | ||
| url = https://github.com/PistonDevelopers/freetype-sys |
Member
There was a problem hiding this comment.
I'm not sure this change belongs here. Can we simply add the configuration define for now?
Author
There was a problem hiding this comment.
android builds fail without this
Author
There was a problem hiding this comment.
harfbuzz-sys has a feature called bundled. But you cannot use the bundled feature with FT enabled unless you link the submodule in the tree since you need the headers. This is needed for platforms where FT is not installed like android.
Author
|
Is there any news on this? It's been months. Your freetype support is broken for Android. I literally had to redo the commit from scratch because of how long it took to respond last time. Then you respond with a one liner and then nothing for months. Come on! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will caused undefined reference for
hb_ft_font_create_referenced(), so I patched the lib to properly include freetype when the feature is enabled.