Implement unclassified reads extraction in sequana_taxonomy - #146
Merged
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 2 medium 1 minor |
🟢 Metrics 14 complexity · 0 duplication
Metric Results Complexity 14 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Extract unclassified reads from kraken output instead of creating empty file. Handles both paired-end and single-end input. Cleanup temp files after merging.
Extract unclassified reads in the sequana_taxonomy/run v1 shell (single- and paired-end, single- and multi-database) and add a standalone sequana_wrappers CLI exposing --version and --stats, wired up via the project scripts.
Stage the NCBI taxonomy DB once into <workdir>/.config/sequana and make every taxonomy rule depend on it, so 4 parallel jobs (-c4) no longer race and corrupt the download (zlib.error: Error -3). Pin XDG_CONFIG_HOME/HOME to the workdir via shell.prefix so the download rule and the frozen get_shell CMD resolve the same config dir (GitHub runners set XDG_CONFIG_HOME=/home/runner/.config, which wins over HOME). Keep rule all as the default target so a run without a host cache does not stop after only downloading the DB. Add paired/2-db fixtures (test_R2_.fastq.gz, toydb2) and adjust the CI workflow accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
kraken/subdirectoryseqkit grepextraction pipeline for unclassified readsTest Plan
sequana_wrappers/shells/sequana_taxonomy/run/test/kraken/unclassified.fastqGenerated with Claude Code