Update examples and benchmarks to use IFileReaderDevice::tryCreateReader.#2188
Open
Dimi1010 wants to merge 5 commits into
Open
Update examples and benchmarks to use IFileReaderDevice::tryCreateReader.#2188Dimi1010 wants to merge 5 commits into
IFileReaderDevice::tryCreateReader.#2188Dimi1010 wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #2188 +/- ##
========================================
Coverage 82.66% 82.66%
========================================
Files 332 332
Lines 60155 60137 -18
Branches 12768 12543 -225
========================================
- Hits 49727 49713 -14
+ Misses 9019 9012 -7
- Partials 1409 1412 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR replaces example usages of deprecated
IFileReaderDevice::getReaderwith the newIFileReaderDevice::createReaderAPI.The majority of the replacements utilize the
tryCreateReaderto minimize the changes due to the non-throwning behaviour ofgetReader.