Skip to content

Update examples and benchmarks to use IFileReaderDevice::tryCreateReader.#2188

Open
Dimi1010 wants to merge 5 commits into
seladb:devfrom
Dimi1010:file-reader-update-examples
Open

Update examples and benchmarks to use IFileReaderDevice::tryCreateReader.#2188
Dimi1010 wants to merge 5 commits into
seladb:devfrom
Dimi1010:file-reader-update-examples

Conversation

@Dimi1010

Copy link
Copy Markdown
Collaborator

The PR replaces example usages of deprecated IFileReaderDevice::getReader with the new IFileReaderDevice::createReader API.

The majority of the replacements utilize the tryCreateReader to minimize the changes due to the non-throwning behaviour of getReader.

@Dimi1010
Dimi1010 requested a review from seladb as a code owner July 18, 2026 17:15
@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.81818% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.66%. Comparing base (3aae85b) to head (1d4acad).

Files with missing lines Patch % Lines
Examples/IPDefragUtil/main.cpp 60.00% 2 Missing and 2 partials ⚠️
Examples/IPFragUtil/main.cpp 55.55% 2 Missing and 2 partials ⚠️
Examples/PcapPrinter/main.cpp 55.55% 2 Missing and 2 partials ⚠️
...amples/PcapPlusPlus-benchmark/benchmark-google.cpp 0.00% 3 Missing ⚠️
Examples/HttpAnalyzer/main.cpp 50.00% 0 Missing and 1 partial ⚠️
Examples/PcapSearch/main.cpp 50.00% 0 Missing and 1 partial ⚠️
Examples/SSLAnalyzer/main.cpp 50.00% 0 Missing and 1 partial ⚠️
Examples/TcpReassembly/main.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##              dev    #2188    +/-   ##
========================================
  Coverage   82.66%   82.66%            
========================================
  Files         332      332            
  Lines       60155    60137    -18     
  Branches    12768    12543   -225     
========================================
- Hits        49727    49713    -14     
+ Misses       9019     9012     -7     
- Partials     1409     1412     +3     
Flag Coverage Δ
23.11.6 7.30% <0.00%> (+0.01%) ⬆️
24.11.5 7.26% <0.00%> (-0.04%) ⬇️
25.11.1 7.28% <0.00%> (-0.02%) ⬇️
alpine320 76.87% <50.00%> (+<0.01%) ⬆️
fedora42 76.45% <50.00%> (-0.01%) ⬇️
macos-15 82.27% <56.81%> (+<0.01%) ⬆️
macos-26 82.28% <56.81%> (+0.01%) ⬆️
macos-26-intel 82.21% <56.81%> (+<0.01%) ⬆️
mingw32 70.98% <ø> (-0.02%) ⬇️
mingw64 70.92% <ø> (+0.04%) ⬆️
npcap ?
rhel94 76.24% <50.00%> (-0.01%) ⬇️
ubuntu2204 76.28% <50.00%> (+<0.01%) ⬆️
ubuntu2404 76.58% <50.00%> (+<0.01%) ⬆️
ubuntu2604 76.53% <50.00%> (+0.01%) ⬆️
ubuntu2604-arm64 76.37% <50.00%> (+<0.01%) ⬆️
ubuntu2604-icpx 59.05% <ø> (-0.03%) ⬇️
unittest 82.66% <56.81%> (+<0.01%) ⬆️
windows-2022 85.81% <ø> (+0.11%) ⬆️
windows-2025 85.54% <ø> (+0.12%) ⬆️
winpcap 85.84% <ø> (+0.20%) ⬆️
xdp 52.92% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant