Improve encapsulation of TextBasedProtocol fields.#2187
Open
Dimi1010 wants to merge 2 commits into
Open
Conversation
…hrough methods instead of direct value mutation. # Conflicts: # Packet++/header/TextBasedProtocol.h
Dimi1010
commented
Jul 14, 2026
Comment on lines
+388
to
+394
| void TextBasedProtocolMessage::validateFieldsOffset(int offset) const | ||
| { | ||
| if (offset < 0 || offset > m_DataLen) | ||
| throw std::invalid_argument( | ||
| "Field offset must be greater or equal to zero and less than or equal to the data length"); | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Maybe this should be std::out_of_range?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #2187 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 332 332
Lines 60154 60161 +7
Branches 12571 12558 -13
=======================================
+ Hits 49724 49731 +7
+ Misses 9021 9017 -4
- Partials 1409 1413 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR changes the visibility of the fields of
TextBasedProtocolfromprotectedtoprivateand establishes methods to allow checked mutation. Notably all offsets are range validated prior to change.