Http 2 client #281

wenxi-zeng · 2025-12-01T22:39:01Z

replace HttpURLConnection with OkHttp

core/src/main/java/com/segment/analytics/kotlin/core/HTTPClient.kt

core/src/main/java/com/segment/analytics/kotlin/core/utilities/OkHttpURLConnection.kt

didiergarcia · 2025-12-02T21:25:55Z

core/src/main/java/com/segment/analytics/kotlin/core/utilities/OkHttpURLConnection.kt

+        val headers = response?.headers ?: return null
+        return if (n in 0 until headers.size) headers.value(n) else null


Same NPE possible?

same here. line 173 response?.headers will already return null

core/src/main/java/com/segment/analytics/kotlin/core/utilities/OkHttpURLConnection.kt

didiergarcia · 2025-12-02T21:29:43Z

core/src/main/java/com/segment/analytics/kotlin/core/utilities/OkHttpURLConnection.kt

+                java.text.SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz", java.util.Locale.US)
+                    .parse(dateStr)?.time ?: 0L
+            } catch (e: Exception) { 0L }
+        } ?: 0L
+    }
+
+    override fun getExpiration(): Long {
+        return getHeaderField("Expires")?.let { dateStr ->
+            try {
+                java.text.SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz", java.util.Locale.US)
+                    .parse(dateStr)?.time ?: 0L
+            } catch (e: Exception) { 0L }
+        } ?: 0L
+    }
+
+    override fun getLastModified(): Long {
+        return getHeaderField("Last-Modified")?.let { dateStr ->
+            try {
+                java.text.SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz", java.util.Locale.US)
+                    .parse(dateStr)?.time ?: 0L
+            } catch (e: Exception) { 0L }
+        } ?: 0L
+    }


I feel like we need a wrapper function for all of those parse() code especially because they have a string to define the format.

core/src/main/java/com/segment/analytics/kotlin/core/utilities/OkHttpURLConnection.kt

didiergarcia

All looks good!

wenxi-zeng added 14 commits October 28, 2025 16:42

create OkHttpURLConnection

727d011

simplify

3d90728

bypass all public methods

e36090f

make okHttpClient customizable

ae3f62e

refactor

059a64c

add unit tests

37e6238

auto convert to post when getOutput is called

ebb1a33

remove gzip from OkHttpURLConnection.kt

9031e54

embed okhttp

b1ab879

fix failed tests

6fe295d

fix failed tests

b4e7dc3

fix flaky tests

96d3800

fix flaky tests

6a7108a

add tests to verify connection is http2

3c7a929