[#5155] Cleaned up unnecessary fake bool usage where appropriate #5156
+31
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hecklezz
force-pushed
the
refactor/fake_bool_cleanup
branch
from
8203e3f to
ac4d7c1
Compare
Ansariel
reviewed
Dec 12, 2025
Contributor
There was a problem hiding this comment.
This header seems to be unused.
Contributor
There was a problem hiding this comment.
This header seems to be unused, too.
Ansariel
reviewed
Dec 12, 2025
Contributor
There was a problem hiding this comment.
This file also seems to be unused.
Hecklezz
force-pushed
the
refactor/fake_bool_cleanup
branch
from
ac4d7c1 to
9543002
Compare
Contributor
Author
|
Dealing with the unused files if they are wanted to be removed is probably best done in another PR as it is out of scope of the current issue. No harm in fixing the fake bools in them in this one though even if unused. |
Contributor
Pulled that one in, looks like there are conflicts in this PR now. |
Signed-off-by: Hecklezz <[email protected]>
Hecklezz
force-pushed
the
refactor/fake_bool_cleanup
branch
from
9543002 to
55cc966
Compare
Contributor
Author
All done, should be no conflicts now. |
akleshchev
approved these changes
Dec 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5155
Note: Probably best to wait for Rye's other PR to be merged first and then I'll rebase this one, as there will be a couple conflicts with him deleting source files- #5153MergedSimply cleans up usages of fake bools where a regular bool is more appropriate, or where function declarations expect a regular bool but a fake bool was used instead.
Fake bool usages in existing APIs such as WinAPI or gtk and others were left untouched as to follow the standards of those libraries.
I also didn't update the fake bool usage for LLPathingLib::createPhysicsCapsuleRep because this would require a change in the LL Havok library to avoid any implicit conversions.