-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add DICOM (Digital Imaging and Communications in Medicine) protocol support #4891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4891 +/- ##
==========================================
- Coverage 80.84% 80.63% -0.22%
==========================================
Files 369 370 +1
Lines 90963 91662 +699
==========================================
+ Hits 73539 73908 +369
- Misses 17424 17754 +330
🚀 New features to boost your workflow:
|
|
Thanks for the PR. I’ve stared the unit tests. Looks good, however, could you please add type hints to your layer? |
Added |
|
Besides the small Flake8 issues, LGTM. @gpotter2 do you want to have a final look? |
|
@polybassa fixed the Flake8 issues |
Summary
DICOM communications is used in medical imaging systems. This PR adds Scapy layers for the DICOM Upper Layer Protocol (DICOM PS3.8).
Features
Usage
Testing
test/contrib/dicom.utsReferences