Add PR template and eslint step to github action#109
Open
seanlim wants to merge 3 commits into
Open
Conversation
seanlim
changed the title
seanlim
requested review from
NicholasT1,
Shamanbenny,
juneha1120,
ngkhengyang and
zzawook
ngkhengyang
requested changes
Jul 1, 2026
ngkhengyang
left a comment
ngkhengyang
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but I think the way the workflow is run can be changed slightly
| @@ -1,10 +1,10 @@ | |||
| name: Tests | |||
| name: Lint and Test | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| name: Lint and Test | |
| name: ci |
Wouldn't naming the entire flow 'ci' and the jobs as linting/testing be more suitable for opening up the workflow for future job additions?
| - run: npm ci | ||
|
|
||
| - run: npm run lint | ||
| - run: npm run test |
Collaborator
There was a problem hiding this comment.
I think it would be better to have testing and linting run as separate jobs so npm run test still runs even if linting fails. It's also easier to see which step passed/failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
eslint.config.mjsto ignore generated coverage artifactsTesting
Ensure GitHub actions run and actually lint and run tests.
Reviewer Notes
.github/pull_request_template.md.github/workflows/test.yml