test: Test other auth methods against fake-seam-connect #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razor-x
commented
Aug 5, 2024
Member
Author
|
@andrii-balitskyi This is low priority, but if you feel like working out this puzzle, it would be nice to find the bug in fake-seam-connect and get the tests passing. Basically, this PR was merged, but something is not implemented right there: seamapi/fake-seam-connect#200 (comment) A good start would be adding a test to fake-seam-connect that reproduced the errors in this PR. |
razor-x
force-pushed
the
unskip-tests
branch
from
c317bd7 to
2810f4e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
@razor-x with fake-seam-connect version 1.74.0 the tests are finally passing! :) |
andrii-balitskyi
approved these changes
Dec 17, 2024
razor-x
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use the changes introduced in seamapi/fake-seam-connect#200 (comment)