Skip to content

Add support for auto-detect when a primary key is also a foreign key in Metadata#2792

Merged
gsheni merged 44 commits intofeature/allow_pk_to_be_fkfrom
issue-2788-metadata-should-be-able-to-auto-detect-cases-where-a-primary-key-is-also-a-foreign-key-column_name_match-algorithm
Feb 4, 2026
Merged

Add support for auto-detect when a primary key is also a foreign key in Metadata#2792
gsheni merged 44 commits intofeature/allow_pk_to_be_fkfrom
issue-2788-metadata-should-be-able-to-auto-detect-cases-where-a-primary-key-is-also-a-foreign-key-column_name_match-algorithm

Conversation

@gsheni
Copy link
Contributor

@gsheni gsheni commented Jan 30, 2026

@gsheni gsheni self-assigned this Jan 30, 2026
@gsheni gsheni requested a review from frances-h January 30, 2026 16:35
@gsheni gsheni requested a review from a team as a code owner January 30, 2026 16:36
@sdv-dev sdv-dev deleted a comment from sdv-team Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.10%. Comparing base (9a0ebd8) to head (4ebdc43).
⚠️ Report is 1 commits behind head on feature/allow_pk_to_be_fk.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/allow_pk_to_be_fk    #2792      +/-   ##
=============================================================
- Coverage                      98.12%   98.10%   -0.02%     
=============================================================
  Files                             73       73              
  Lines                           8141     8148       +7     
=============================================================
+ Hits                            7988     7994       +6     
- Misses                           153      154       +1     
Flag Coverage Δ
integration 75.51% <100.00%> (+0.08%) ⬆️
unit 97.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gsheni gsheni force-pushed the issue-2788-metadata-should-be-able-to-auto-detect-cases-where-a-primary-key-is-also-a-foreign-key-column_name_match-algorithm branch from 883c11d to 216b521 Compare February 3, 2026 22:15
@sdv-dev sdv-dev deleted a comment from sdv-team Feb 4, 2026
Base automatically changed from issue-2779-allow-a-primary-key-to-also-be-a-foreign-key-in-the-metadata-and-also-for-modeling to feature/allow_pk_to_be_fk February 4, 2026 16:36
@sdv-dev sdv-dev deleted a comment from sdv-team Feb 4, 2026
@sdv-dev sdv-dev deleted a comment from sdv-team Feb 4, 2026
@gsheni gsheni merged commit a9fa60d into feature/allow_pk_to_be_fk Feb 4, 2026
47 checks passed
@gsheni gsheni deleted the issue-2788-metadata-should-be-able-to-auto-detect-cases-where-a-primary-key-is-also-a-foreign-key-column_name_match-algorithm branch February 4, 2026 21:05
@gsheni gsheni restored the issue-2788-metadata-should-be-able-to-auto-detect-cases-where-a-primary-key-is-also-a-foreign-key-column_name_match-algorithm branch February 13, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants