Allow a primary key to also be a foreign key in the metadata and for modeling#2790
Merged
gsheni merged 39 commits intofeature/allow_pk_to_be_fkfrom Feb 4, 2026
Conversation
Contributor
gsheni
commented
Jan 26, 2026
- Fixes Allow a primary key to also be a foreign key (in the metadata and also for modeling) #2779
- CU-86b84tfje
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/allow_pk_to_be_fk #2790 +/- ##
=============================================================
+ Coverage 98.13% 98.14% +0.01%
=============================================================
Files 73 73
Lines 8079 8092 +13
=============================================================
+ Hits 7928 7942 +14
+ Misses 151 150 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-primary-key-to-also-be-a-foreign-key-in-the-metadata-and-also-for-modeling
gsheni
commented
Jan 26, 2026
| @@ -910,12 +903,18 @@ def test_no_duplicated_foreign_key_relationships_are_generated(): | |||
Contributor
Author
There was a problem hiding this comment.
I believe this integration test will change once detect_from_dataframes is updated:
#2788
I modified it to allow it to pass but it is flaky.
fealho
reviewed
Jan 26, 2026
frances-h
approved these changes
Jan 30, 2026
fealho
reviewed
Jan 31, 2026
pvk-developer
approved these changes
Feb 2, 2026
fealho
approved these changes
Feb 3, 2026
fealho
approved these changes
Feb 3, 2026
pvk-developer
approved these changes
Feb 4, 2026
Member
pvk-developer
left a comment
There was a problem hiding this comment.
Just two suggestions but LGTM.
frances-h
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.