(chore): derive CI matrix from hatch env#3607
Merged
flying-sheep merged 14 commits intomainfrom May 27, 2025
Merged
Conversation
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
ilan-gold
reviewed
May 16, 2025
Contributor
ilan-gold
left a comment
ilan-gold
left a comment
There was a problem hiding this comment.
Few comments/questions
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
3 tasks
ilan-gold
approved these changes
May 27, 2025
flying-sheep
added a commit
that referenced
this pull request
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/scverse/cookiecutter-scverse/blob/d4bdfc5ec4c5029aebf7c0cba65609e20358144d/%7B%7Bcookiecutter.project_name%7D%7D/.github/workflows/test.yaml
This also updates the hatch env matrix to have the following jobs
stable(formerlyfull): run all pretty much tests except external toolspre(unchanged): run tests with pre-release versionsmin-vers(formerlymin): run tests with the minimum possible versionsmin-deps(new): like in anndata, tests if everything imports OK with no optional dependencies installedThe only regression is that we no longer test
scanorama, because it depends onannoy, which hasn’t been updated in years and fails to build on my system.We should probably think of a better strategy for it, but I think running the maximum set of tests that we test online also locally is a good idea.
We also need to check if codecov still works, I’m typing this while tests still run.