feat: Add SwiftUI About tab for Scribe-Conjugate#626
feat: Add SwiftUI About tab for Scribe-Conjugate#626prince-0408 wants to merge 7 commits intoscribe-org:mainfrom
Conversation
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
Would you be able to fix the conflicts on the Thanks so much for sending along all of these PRs! The work here is looking great, and we're looking forward to bringing it in :) |
|
Hey @andrewtavis, the issue with |
|
Hey @prince-0408 👋 I'm currently getting |
|
Hey @andrewtavis! Appreciate you bringing this to our attention . Yeah, I'm seeing the same issue of |
|
Thanks for looking into this, @prince-0408! Hope it's ok that I merged in main and did some reformatting for you as I decided to switch the codebase over to four spaces and do a lot of much needed formatting. note: The one thing I'm seeing here as of now is that the Bluesky icon isn't being shown. Could you look into this and confirm when it's there and we're ready for a review? |
|
A few more points here, @prince-0408:
Please let us know when the above's ready for another review :) |
|
Hi @andrewtavis, all points addressed in the latest commit:
Let me know if anything else needs adjusting!
|
- Implement AboutTab with Community, Feedback and support, and Legal sections - Add AboutSectionView, AboutRowView, AboutTipCardView, AboutInfoView, ShareSheet - Use Conjugate-specific share text and dynamic version number from bundle - Add Bluesky row with butterfly icon asset - Add detail screens for Wikimedia, Privacy Policy, and Third-party licenses - Matches Figma design for Conjugate About tab Closes scribe-org#607
…gationViewController from Conjugate target These files are Scribe keyboard app-only and were incorrectly included in the Conjugate app target, causing 'Cannot find type' build errors. None of them are used by the Conjugate app.
…njugate target Both files depend on DownloadStateManager which is Scribe-app-only, causing 'Cannot find type DownloadStateManager' build errors in the Conjugate target.
- Fix Bluesky icon not visible in dark mode by adding invertIconInDarkMode parameter to AboutRowView; applies colorInvert() when colorScheme == .dark, avoiding the need for a separate dark-mode asset - Fix subpage navigation headers (Third-party licenses, Wikimedia and Scribe, Privacy policy) appearing inside the view by changing navigationBarTitleDisplayMode from .inline to .large so titles render above the content in the nav bar - Replace tooltip text 'Tap a row to learn more or take action.' with the shared Scribe i18n key i18n.app.about.app_hint_tooltip, aligning with the string used in the Keyboard app: 'Here's where you can learn more about Scribe and its community.'
2b88493 to
ba5131b
Compare


About Tab — Scribe-Conjugate (
SwiftUI)Closes #607
Overview
Implements the About tab for Scribe-Conjugate in SwiftUI, mirroring the structure of the existing Scribe keyboard About tab (UIKit) while adapting content and links specifically for the Conjugate app.
New Files
Sections Implemented
Community
Wikimedia and Scribe → navigates to detail screen
Feedback and Support
Legal