Info form by catreedle · Pull Request #595 · scribe-org/Scribe-iOS

catreedle · 2026-03-02T09:30:23Z

Contributor checklist

This pull request is on a separate branch and not the main branch
I have tested my code with the xcodebuild and swiftlint --strict commands as directed in the testing section of the contributing guide

Description

This PR removes old in-command state keyboard setups from Keyboard.xib and KeyboardViewController and refactor "Not in wikidata" info tooltip to use dynamic key form view.

Changes:

Remove unused keys elements from Keyboard.xib, its contraints and fix constraint
Remove unused keys elements initiation, its setup, and related functions from KeyboardViewController, change how information tooltip is shown
Set up showing information tooltip in DynamicConjugationViewController.swift and NavigationStructure.swift
Delete ToolTipViewDatasource.swift, ToolTipViewTheme.swift, ToolTipViewDatasourceable.swift, ToolTipViewUpdatable.swift, ViewThemeable.swift, ToolTipView.swift that are no longer used

Related issue

Remove XIB-based 1x1 form display and convert to programmatic UI #594

github-actions · 2026-03-02T09:30:48Z

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

github-actions · 2026-03-02T09:30:48Z

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed
The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

andrewtavis · 2026-03-05T00:57:35Z

So great to have this, @catreedle! Do you want to maybe add in the work for #597 here? I'm realizing we need strings for the "Not in Wiktionary" description for the user. I can add those into Scribe-i18n now and maybe we can make the change so that all of this part is finalized?

andrewtavis · 2026-03-05T01:16:33Z

The latest commit to main updated Scribe-i18n, @catreedle :) Feel free to use those new strings for the message about Wiktionary not being available, and for the Not in Wiktionary you can just translate the strings for the interface fields :)

andrewtavis · 2026-03-05T01:16:53Z

Please let me know if you have questions or if you'd prefer to prioritize something else!

catreedle · 2026-03-05T03:49:44Z

Please let me know if you have questions or if you'd prefer to prioritize something else!

Thank you! I will look into this soon. :)

catreedle · 2026-03-05T06:20:51Z

hi @andrewtavis the change applies to only translation command, right?
conjugate and plural will still use the old messages?

andrewtavis · 2026-03-05T07:43:21Z

Yes exactly, @catreedle 😊

catreedle · 2026-03-05T08:04:13Z

Yes exactly, @catreedle 😊

Okay. working on it :)

catreedle · 2026-03-05T10:46:32Z

still need to look into the localization, currently the invalid description is always using fallback value.

catreedle · 2026-03-05T16:50:52Z

it seems that for wikidata, the invalid description follows device's language, not the Scribe's keyboard language. Which language should it follow @andrewtavis ?
as for the wiktionary localizations, it needs to be generated for other languages besides English. is there a script for this?

andrewtavis · 2026-03-07T14:54:30Z

We don't have a script for this, @catreedle. We can just use an online translator for some of these scripts :) If there's an issue, it can be fixed by the community. We can also check the languages we all speak 😊

andrewtavis · 2026-03-07T14:55:13Z

Feel free to send along the translations and we should be good to go after that!

andrewtavis · 2026-03-07T15:13:16Z

Notes from the sync: We do need these texts coming from Scribe-i18n, and for now they do not need to be localized. If they don't have a text in a locale, then it should be defaulted to English :)

What was writtne out:

We should only use the keyboard language
Do we hard code the "Not in..." texts into the interface variables, or do we use Scribe-i18n?
If we do have localizations for the strings in the keyboard language, then put them in the interface file
If we don't, let's hard code them and translate them
If we don't have the keyboard, but we do have the localization, then let's make an interface file and just save the strings in the needed variables so that these localizations don't go to waste
Then we delete the following strings from Scribe-i18n:
- i18n.app.keyboard.not_in_wikidata.explanation_1
- i18n.app.keyboard.not_in_wikidata.explanation_2
- i18n.app.keyboard.not_in_wikidata.explanation_3
- i18n.app.keyboard.not_in_wiktionary.explanation_1
- i18n.app.keyboard.not_in_wiktionary.explanation_2
- i18n.app.keyboard.not_in_wiktionary.explanation_3

* chore: add invalidCommandMsgWiktionary variable to language interface files * fix: show Not in Wiktionary for translate and Not in Wikidata for conjugate and plural * test: update keyboard styling tests for Wikidata and Wiktionary invalid command messages * Update Scribe-i18n, use new hard coded strings for not in Wikidata message * Remove trailing commas --------- Co-authored-by: Andrew Tavis McAllister <andrew.t.mcallister@gmail.com>

* feat:use swift ui for conjugate app * chore: removed unncessary files in build phase * fix:linting issues * Update ConjugateTab.swift with license header Removed unnecessary comments and added SPDX license header. * Update Scribe-i18n to fix merge conflicts --------- Co-authored-by: Andrew Tavis McAllister <andrew.t.mcallister@gmail.com>

andrewtavis · 2026-03-24T16:37:24Z

We have conflicts in the .xcodeproj from merging in the download functionality, @catreedle :) Could you fix them?

andrewtavis · 2026-03-24T18:58:47Z

praise: So great to see all of these deletions here, @catreedle! Amazing work!

one note: As of now the translate command seems to break the keyboard. I can get to the command, but when I enter in text and execute the command the keyboard breaks and reverts to a system keyboard. Could we take a look at this? Maybe it's something having to do with the Wiktionary texts or something like this?

andrewtavis · 2026-03-24T21:01:07Z

further note, @catreedle: It looks like translate is broken on main... Not sure when this came in, but we can potentially move on from this and open an issue. I'll be merging in something to format the codebase shortly ✨

andrewtavis · 2026-03-24T21:25:17Z

@catreedle, the merge conflicts are because of the formatting that just went through on the files you're deleting, so hopefully they're able to be fixed. Let us know if you need some support here with them :)

Once this is finalized we can bring this in and make an issue for translate not working 😊

…-org#624) - Replace RadioCircle with CheckDataSpinner component - Add three states: idle (gray circle), checking (rotating arc + X cancel), checked (filled orange + checkmark) - Animate spinner using Timer at ~60fps for smooth rotation - Tap X during check to cancel back to idle - Auto-transitions to checked state after check completes Co-authored-by: Andrew Tavis McAllister <andrew.t.mcallister@gmail.com>

scribe-org#628) * Convert project over to using Swift standard of four spaces and format all files * Rename swiftlint file * Edit swiftlint rules - comment out some * Edit swiftlint rules - ignore some

catreedle · 2026-03-25T12:30:06Z

@catreedle, the merge conflicts are because of the formatting that just went through on the files you're deleting, so hopefully they're able to be fixed. Let us know if you need some support here with them :)

Once this is finalized we can bring this in and make an issue for translate not working 😊

fixed the conflict. sure I will look into that :)

andrewtavis · 2026-03-26T23:45:03Z

Keyboards/LanguageKeyboards/Danish/DAInterfaceVariables.swift


-func setDAKeyboardLayout() {}
+func setDAKeyboardLayout() {
+  invalidCommandMsgWikidata = "Findes ikke i Wikidata"


Great to have these :) Thanks, @catreedle!

catreedle added 5 commits February 27, 2026 13:20

refactor: remove old form elements

bb68cbb

feat: set information tooltip to use dynamic form

ea4b161

remove left and right button components from Keyboard.xib and controller

6a90440

delete unused Tooltip files

a6cb9d5

fix title display command

c0a6ff5

andrewtavis self-requested a review March 5, 2026 02:18

Update Scribe-i18n

1a6ccde

catreedle added 2 commits March 5, 2026 16:05

add invalid message for invalid translation

2aee4d2

add invalid information texts for invalid translation

706ac74

add language extensions target for Localizable.xcstrings

377e14f

Merge branch 'scribe-org:main' into info-form

840c69d

andrewtavis and others added 4 commits March 17, 2026 09:45

Switch project over to using prek and update Scribe-i18n

8acb6ae

Add mentorship and growth to contriburing and fix toc navigation

83d88ae

Fix broken contributing link

d54037f

add info tooltip invalid command translations scribe-org#597

2f17265

andrewtavis mentioned this pull request Mar 21, 2026

Download from API #593

Merged

2 tasks

shabicha and others added 9 commits March 24, 2026 16:44

add invalid message for invalid translation

4ed6ca0

add invalid information texts for invalid translation

50f7023

add info tooltip invalid command translations scribe-org#597

4c90352

Merge branch 'main' into info-form

1323985

fix merge conflict variables

e883409

fix merge conflict variables

c369978

Merge branch 'main' into info-form

b1f02c2

catreedle and others added 2 commits March 24, 2026 23:55

Merge branch 'main' into info-form

d2be7ff

Merge branch 'main' into info-form

054c118

prince-0408 and others added 12 commits March 25, 2026 14:49

Convert project over to using Swift standard of four spaces and format (

80b5bc1

scribe-org#628) * Convert project over to using Swift standard of four spaces and format all files * Rename swiftlint file * Edit swiftlint rules - comment out some * Edit swiftlint rules - ignore some

Order imports

af3a380

Update repo workflows

11924e1

Minor workflow update

55591cb

refactor: remove old form elements

ddb14de

remove left and right button components from Keyboard.xib and controller

f7125ab

delete unused Tooltip files

16e5f66

Merge remote-tracking branch 'origin/main' into info-form

077d4be

remove unused func createInformationStateDatasource

43d9295

fix build error after InformationToolTip merge conflict

ee7f22d

fix swiftlint error

03602f5

andrewtavis reviewed Mar 26, 2026

View reviewed changes

Conversation

catreedle commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contributor checklist

Description

Related issue

Uh oh!

github-actions bot commented Mar 2, 2026

Thank you for the pull request! 💙

Uh oh!

github-actions bot commented Mar 2, 2026

Maintainer Checklist

Uh oh!

andrewtavis commented Mar 5, 2026

Uh oh!

andrewtavis commented Mar 5, 2026

Uh oh!

andrewtavis commented Mar 5, 2026

Uh oh!

catreedle commented Mar 5, 2026

Uh oh!

catreedle commented Mar 5, 2026

Uh oh!

andrewtavis commented Mar 5, 2026

Uh oh!

catreedle commented Mar 5, 2026

Uh oh!

catreedle commented Mar 5, 2026

Uh oh!

catreedle commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewtavis commented Mar 7, 2026

Uh oh!

andrewtavis commented Mar 7, 2026

Uh oh!

andrewtavis commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewtavis commented Mar 24, 2026

Uh oh!

andrewtavis commented Mar 24, 2026

Uh oh!

andrewtavis commented Mar 24, 2026

Uh oh!

andrewtavis commented Mar 24, 2026

Uh oh!

catreedle commented Mar 25, 2026

Uh oh!

andrewtavis Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

catreedle commented Mar 2, 2026 •

edited

Loading

catreedle commented Mar 5, 2026 •

edited

Loading

andrewtavis commented Mar 7, 2026 •

edited

Loading