Skip to content

Remove autocomplete_lexicon generation logic#677

Open
Vishuzz wants to merge 1 commit intoscribe-org:mainfrom
Vishuzz:main
Open

Remove autocomplete_lexicon generation logic#677
Vishuzz wants to merge 1 commit intoscribe-org:mainfrom
Vishuzz:main

Conversation

@Vishuzz
Copy link
Copy Markdown

@Vishuzz Vishuzz commented Mar 27, 2026

Contributor checklist

  • This pull request is on a separate branch.
  • I verified syntax using python -m py_compile src/scribe_data/load/data_to_sqlite.py.

Description

Removed obsolete autocomplete_lexicon generation logic from src/scribe_data/load/data_to_sqlite.py.

Changes made:

  • removed forced specific_tables append logic
  • removed skip condition in loop
  • removed separate SQL generation block

Since autocomplete_lexicon is already absent from data_type_metadata.yaml, this cleans up dead runtime logic only.

Related issue

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the pull request! 💙🩵

The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo (can be set with git config --global user.email "GITHUB_EMAIL")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unneeded autocomplete_lexicon from project

1 participant