Skip to content

fix: remove unneeded autocomplete_lexicon from project (#667)#675

Open
keerthanakh89 wants to merge 1 commit intoscribe-org:mainfrom
keerthanakh89:fix/remove-autocomplete
Open

fix: remove unneeded autocomplete_lexicon from project (#667)#675
keerthanakh89 wants to merge 1 commit intoscribe-org:mainfrom
keerthanakh89:fix/remove-autocomplete

Conversation

@keerthanakh89
Copy link
Copy Markdown

Fixes #667

Changes Made

  • Removed the if specific_tables and "autocomplete_lexicon" in specific_tables block
  • Removed the entire autocomplete_lexicon SQL query block
  • Removed continue # handled separately check
  • Removed the condition checking for autocomplete_lexicon subset
  • Cleaned up emoji_keywords handling
  • All 12 references to autocomplete_lexicon have been removed

The code now processes only actual JSON tables without
generating the derived autocomplete_lexicon table.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the pull request! 💙🩵

The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo (can be set with git config --global user.email "GITHUB_EMAIL")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unneeded autocomplete_lexicon from project

1 participant