Make importing memory queues from the package possible#55
Open
CrazyPython wants to merge 1 commit intoscrapy:masterfrom
Open
Make importing memory queues from the package possible#55CrazyPython wants to merge 1 commit intoscrapy:masterfrom
CrazyPython wants to merge 1 commit intoscrapy:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 310 310
Branches 38 38
=========================================
Hits 310 310 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wRAR
approved these changes
Jul 26, 2021
Member
|
I wonder if we should take the chance to cover them in the README as well, for discoverability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now to use the memory queues, we have to do this:
This PR lets us do this:
This has readability gains because it means we can write:
Instead of:
Unless this is intentional to discourage using non-disk queues, this change should improve library ergonomics.