Skip to content

feat(plasma-icons): Add icons for 36 dp from P to W#1172

Open
neretin-trike wants to merge 2 commits intomasterfrom
icon-export-6hbb1vp52g
Open

feat(plasma-icons): Add icons for 36 dp from P to W#1172
neretin-trike wants to merge 2 commits intomasterfrom
icon-export-6hbb1vp52g

Conversation

@neretin-trike
Copy link
Copy Markdown
Contributor

@neretin-trike neretin-trike commented Mar 30, 2022

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @sberdevices/demo-canvas-app@0.68.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
npm install @sberdevices/plasma-b2c@1.54.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
npm install @sberdevices/plasma-core@1.54.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
npm install @sberdevices/plasma-icons@1.73.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
npm install @sberdevices/plasma-temple@1.49.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
npm install @sberdevices/plasma-ui@1.91.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
npm install @sberdevices/plasma-web@1.89.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
npm install @sberdevices/plasma-sb-utils@0.53.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
npm install @sberdevices/showcase@0.110.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
npm install @sberdevices/plasma-ui-docs@0.59.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
npm install @sberdevices/plasma-web-docs@0.47.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
npm install @sberdevices/plasma-website@0.44.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
# or 
yarn add @sberdevices/demo-canvas-app@0.68.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
yarn add @sberdevices/plasma-b2c@1.54.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
yarn add @sberdevices/plasma-core@1.54.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
yarn add @sberdevices/plasma-icons@1.73.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
yarn add @sberdevices/plasma-temple@1.49.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
yarn add @sberdevices/plasma-ui@1.91.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
yarn add @sberdevices/plasma-web@1.89.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
yarn add @sberdevices/plasma-sb-utils@0.53.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
yarn add @sberdevices/showcase@0.110.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
yarn add @sberdevices/plasma-ui-docs@0.59.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
yarn add @sberdevices/plasma-web-docs@0.47.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0
yarn add @sberdevices/plasma-website@0.44.0-canary.1172.6f4103142ce2b41a18060d7cd94481ff62a0ae71.0

@neretin-trike neretin-trike requested a review from OgNellis as a code owner March 30, 2022 08:40
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2022

Codecov Report

Merging #1172 (0bfdf85) into master (87336eb) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
- Coverage   89.04%   88.71%   -0.34%     
==========================================
  Files         435      426       -9     
  Lines        5879     5758     -121     
  Branches     1679     1658      -21     
==========================================
- Hits         5235     5108     -127     
- Misses        643      649       +6     
  Partials        1        1              
Flag Coverage Δ
plasma-b2c 95.86% <ø> (ø)
plasma-core 94.95% <ø> (+0.01%) ⬆️
plasma-temple 81.15% <ø> (-1.14%) ⬇️
plasma-ui 94.42% <ø> (+0.02%) ⬆️
plasma-web 96.11% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/plasma-temple/src/utils/scroll.ts 0.00% <0.00%> (-82.36%) ⬇️
.../src/components/StateLayout/StateLayout@mobile.tsx 94.73% <0.00%> (-5.27%) ⬇️
...ges/plasma-ui/src/components/Radiobox/Radiobox.tsx 100.00% <0.00%> (ø)
...es/plasma-temple/src/pages/ErrorPage/ErrorPage.tsx 100.00% <0.00%> (ø)
...es/plasma-web/src/components/Checkbox/Checkbox.tsx 100.00% <0.00%> (ø)
...es/plasma-web/src/components/Radiobox/Radiobox.tsx 100.00% <0.00%> (ø)
...-temple/src/pages/GridPage/components/GridCard.tsx 100.00% <0.00%> (ø)
.../src/components/StateLayout/StateLayout@common.tsx 100.00% <0.00%> (ø)
...src/components/StateLayout/StateLayout@sberbox.tsx 100.00% <0.00%> (ø)
.../components/StateLayout/StateLayout@sberportal.tsx 100.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fbd2b1...0bfdf85. Read the comment docs.

@SberDevices-Eva
Copy link
Copy Markdown
Collaborator

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1172/

@SberDevices-Eva
Copy link
Copy Markdown
Collaborator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants