review: expose failed review diagnostics in raw logs#213
Open
smcdef wants to merge 1 commit into
Open
Conversation
Review failures were stored as review-level result descriptions, while the patchset page mostly surfaced patchset.failed_reason. When the review worker failed before producing a final JSON payload, the raw log page could also be empty because no interaction logs had been persisted. Keep patchset details concise and route failure diagnosis through the existing raw-log link. Make the raw log page show the final failure reason above the interaction log, then fall back to saved raw output or input context when no structured interaction log was recorded. Capture partial stdout, stderr, and AI turn summaries while the review tool runs, keep those logs if completion later stores no log payload, and store process output with explicit process-log metadata so it can be rendered separately from AI interactions. Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Author
|
After apply the patch, developers will know the reason about the failure. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review failures were stored as review-level result descriptions, while the patchset page mostly surfaced patchset.failed_reason. When the review worker failed before producing a final JSON payload, the raw log page could also be empty because no interaction logs had been persisted.
Keep patchset details concise and route failure diagnosis through the existing raw-log link. Make the raw log page show the final failure reason above the interaction log, then fall back to saved raw output or input context when no structured interaction log was recorded.
Capture partial stdout, stderr, and AI turn summaries while the review tool runs, keep those logs if completion later stores no log payload, and store process output with explicit process-log metadata so it can be rendered separately from AI interactions.