[codex] fix unordered application command arrays#866
Draft
valipuha wants to merge 1 commit intosapphiredev:mainfrom
Draft
[codex] fix unordered application command arrays#866valipuha wants to merge 1 commit intosapphiredev:mainfrom
valipuha wants to merge 1 commit intosapphiredev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integration_typesandcontextsas unordered sets when computing application command differencesRoot cause
The command diff logic compared
integration_typesandcontextspositionally, so semantically equivalent arrays with a different order were reported as changes.Validation
corepack yarn vitest run tests/application-commands/computeDifferences.test.tscorepack yarn typecheckFixes #865.