Skip to content

[codex] fix unordered application command arrays#866

Draft
valipuha wants to merge 1 commit intosapphiredev:mainfrom
valipuha:codex/fix-unsorted-command-arrays
Draft

[codex] fix unordered application command arrays#866
valipuha wants to merge 1 commit intosapphiredev:mainfrom
valipuha:codex/fix-unsorted-command-arrays

Conversation

@valipuha
Copy link
Copy Markdown

Summary

  • treat integration_types and contexts as unordered sets when computing application command differences
  • avoid unnecessary command updates when the same values are provided in a different order
  • add regression coverage for both unsorted array cases

Root cause

The command diff logic compared integration_types and contexts positionally, so semantically equivalent arrays with a different order were reported as changes.

Validation

  • corepack yarn vitest run tests/application-commands/computeDifferences.test.ts
  • corepack yarn typecheck

Fixes #865.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: command always updates when setIntegrationTypes or setContexts arrays are unsorted

1 participant