3.4.0 #402
3.4.0 #402
Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to be a work-in-progress version bump that is incomplete and inconsistent. The PR title "3.4.0" suggests a version update, but the changes show:
- The auto-generated
index.htmlfile was manually edited to show version "3.4.0" - The actual version files (
versionandmain.pyVERSION constant) remain at "3.3.0", creating a mismatch - Additional AI-related keywords were added to the frequency words configuration
- The GitHub Actions workflow schedule was changed from hourly to twice daily
Key Changes
- Manual edit to auto-generated HTML:
index.htmlnow displays "发现新版本 3.4.0，当前版本 3.3.0" but this file should be generated by the Python script, not edited directly - Frequency words expansion: Added 31 AI-related tool and model names to
config/frequency_words.txt - Workflow schedule change: Modified cron schedule from
"0 * * * *"(hourly) to"0 1,12 * * *"(twice daily at 1 AM and 12 PM UTC)
Reviewed changes
Copilot reviewed 17 out of 181 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
index.html |
Manually edited auto-generated file showing inconsistent version information |
config/frequency_words.txt |
Added 31 new AI tool/model keywords for trending topic detection |
.github/workflows/crawler.yml |
Changed execution frequency from hourly to twice daily |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
index.html
Outdated
| </a> | ||
| <br> | ||
| <span style="color: #ea580c; font-weight: 500;"> | ||
| 发现新版本 3.4.0，当前版本 3.3.0 |
There was a problem hiding this comment.
The index.html file is auto-generated by main.py (lines 1703-1705) and should not be manually edited. This entire file will be overwritten the next time the Python script runs. To properly update the version message, you should update the VERSION constant in main.py (line 23) and the version file instead. The version information in this HTML is also inconsistent - it claims the current version is 3.3.0 but shows an update available to 3.4.0, when the actual code version is still 3.3.0.
| 发现新版本 3.4.0，当前版本 3.3.0 | |
| <!-- Version information is auto-generated. Update VERSION in main.py and the version file, then regenerate this file. --> |
| schedule: | ||
| - cron: "0 * * * *" | ||
| # 我们使用的是 github 官方提供的资源来进行的推送，而每个账号的资源是限额的，为了不被官方判定为滥用而面临封号的风险，不建议比半小时更低 | ||
| - cron: "0 1,12 * * *" # 每小时整点运行一次(实际有偏差) 或者 "*/30 * * * *" (每半小时执行一次) 或者 "*/30 0-14 * * *"(每天早上 8 点到晚上 10 点期间，每半小时运行一次) |
There was a problem hiding this comment.
The comment is incorrect and outdated. It says '每小时整点运行一次' (runs every hour on the hour) but the actual cron expression 0 1,12 * * * runs only twice daily at 1 AM and 12 PM UTC. The comment should be updated to accurately reflect the new schedule, for example: '每天1点和12点运行两次 (UTC时间)' (runs twice daily at 1 AM and 12 PM UTC).
| - cron: "0 1,12 * * *" # 每小时整点运行一次(实际有偏差) 或者 "*/30 * * * *" (每半小时执行一次) 或者 "*/30 0-14 * * *"(每天早上 8 点到晚上 10 点期间，每半小时运行一次) | |
| - cron: "0 1,12 * * *" # 每天1点和12点运行两次 (UTC时间)，或者 "*/30 * * * *" (每半小时执行一次)，或者 "*/30 0-14 * * *"(每天早上 8 点到晚上 10 点期间，每半小时运行一次) |
2 participants
No description provided.