Updated SubsetEq.conclude() to better accommodate basic SetOfAll() #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update SubsetEq.conclude() method to deal more correctly with the special case of "basic" SetOfAll set comprehensions. Errors has been recently encountered due to some older code in the conclude() method. The use of SetOfAll.explicit_conditions() (instead of the more general .conditions()) and wrapping conditions in a logical And() seems to have corrected the most basic problems. Commit also includes updated related demonstrations ntoebook in logic/sets/inclusion and minor addition to demonstrations notebook in logic/sets/comprehension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates the
SubsetEq.conclude()method (in logic/sets/inclusion) to deal more correctly with the special case of "basic"SetOfAllset comprehensions. Some errors had recently been encountered due to some older code in the conclude() method. The use ofSetOfAll.explicit_conditions()(instead of the more general .conditions()) and wrapping conditions in a logicalAnd()seems to have corrected the most basic problems. Branch also includes updated related demonstrations notebook in logic/sets/inclusion and minor addition to demonstrations notebook in logic/sets/comprehension.