Stop bgzf_index_dump_hfile() from writing invalid item counts#1988
Merged
vasudeva8 merged 1 commit intosamtools:developfrom Mar 5, 2026
Merged
Stop bgzf_index_dump_hfile() from writing invalid item counts#1988vasudeva8 merged 1 commit intosamtools:developfrom
vasudeva8 merged 1 commit intosamtools:developfrom
Conversation
Adds `fp->idx->noffs > 0` checks before decrementing the item count written to GZI indexes. Fixes a bug where the wrong value was written when compressing and GZI indexing an empty file. Note that since 6dd0d7d, files exhibiting this bug will be rejected by bgzf_index_load_hfile(). Thanks to Matthieu Muffato for reporting this bug.
daviesrob
force-pushed
the
bad-gzi-prevention
branch
from
cf2d738 to
cf6bb09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
fp->idx->noffs > 0checks before decrementing the item count written to GZI indexes. Fixes a bug where the wrong value was written when compressing and GZI indexing an empty file. Note that since 6dd0d7d, files exhibiting this bug will be rejected bybgzf_index_load_hfile().Thanks to Matthieu Muffato for reporting this bug.