Implement FHIR Types in Java#2989
Closed
alexanderkiel wants to merge 1 commit intomainfrom
Closed
Conversation
alexanderkiel
force-pushed
the
fhir-types-java
branch
5 times, most recently
from
0c03fa1 to
ab2c3e8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2989 +/- ##
==========================================
+ Coverage 95.50% 95.86% +0.35%
==========================================
Files 401 397 -4
Lines 25430 24679 -751
Branches 716 633 -83
==========================================
- Hits 24288 23659 -629
+ Misses 539 499 -40
+ Partials 603 521 -82
🚀 New features to boost your workflow:
|
alexanderkiel
force-pushed
the
fhir-types-java
branch
14 times, most recently
from
ceed128 to
80f43dd
Compare
alexanderkiel
force-pushed
the
fhir-types-java
branch
8 times, most recently
from
b7c7c6f to
cd4e8ff
Compare
alexanderkiel
force-pushed
the
fhir-types-java
branch
8 times, most recently
from
f18903f to
9033cfa
Compare
alexanderkiel
force-pushed
the
fhir-types-java
branch
2 times, most recently
from
c504381 to
9263ee7
Compare
alexanderkiel
force-pushed
the
fhir-types-java
branch
8 times, most recently
from
b56e49a to
416d54f
Compare
alexanderkiel
force-pushed
the
fhir-types-java
branch
8 times, most recently
from
678ff5b to
5982fc3
Compare
knoppiks
requested changes
Jan 12, 2026
| **Default:** 128 | ||
|
|
||
| #### `DB_RESOURCE_CACHE_SIZE` <Badge type="warning" text="Since 0.8"/> | ||
| #### `DB_RESOURCE_CACHE_SIZE` <Badge type="warning" text="Since 0.8"/> <Badge type="danger" text="unreleased"/> |
Collaborator
There was a problem hiding this comment.
Unreleased AND deprecated? For those who used the development versions?
Member
Author
There was a problem hiding this comment.
yes the deprecation is unreleased
| @@ -1,4 +1,4 @@ | |||
| FROM eclipse-temurin:21.0.9_10-jre-noble@sha256:67fc762eabacb56e5444b367889e04ce8c839b8f4b3d8ef3e459c5579fbefd8a | |||
| FROM eclipse-temurin:25-jre-noble | |||
Collaborator
There was a problem hiding this comment.
eclipse-temurin:25 no longer ships curl. This will probably break docker compose health checks.
| Keyword FHIR_TYPE_BUNDLE_ENTRY = RT.keyword("fhir.Bundle", "entry"); | ||
|
|
||
| int MEM_SIZE_OBJECT_HEADER = 8; | ||
| int MEM_SIZE_PERSISTENT_VECTOR_OBJECT = 40; |
Collaborator
There was a problem hiding this comment.
Looks like magic numbers, can we document them?
| hashIntoMap(m, sink); | ||
| break; | ||
| case List<?> l: | ||
| sink.putByte((byte) 36); |
Member
Author
|
Solved by #3259 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.