Implement options package for cross-type transformations#4
Open
Fryuni wants to merge 1 commit intosamber:masterfrom
Open
Implement options package for cross-type transformations#4Fryuni wants to merge 1 commit intosamber:masterfrom
Fryuni wants to merge 1 commit intosamber:masterfrom
Conversation
Author
|
Just found that what I called |
Author
|
@samber any thoughts about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated on the package doc:
This package includes:
options.Mapoptions.FlatMapoptions.Matchoptions.FlatMatchThe
FlatMatchfunction is to replace this pattern:I would have this be the behavior of
Matchand return anOptionwhen wanted, but since there is already a method that use the two return values I decided to have the same signature for the function with same name and create a new function for this pattern. I called itFlatMatchsince it allows the same use case asFlatMap, where the given functions return anOptionand the result is that sameOption.If you agree with this idea I can send a
resultspackage right away.