Avoid splitting undefined capture output - #65
Open
salva wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a list-context edge case in Net::OpenSSH->capture where, after an _io3 decoding/stream error, the method could attempt to split an undefined $output. It aligns capture’s list-context behavior with the failure semantics described in issue #43 by returning an empty list early when no output was produced.
Changes:
- In
capture, return()in list context when_io3returns undefined output (avoids splitting undef). - Add an integration assertion ensuring list-context
capturereturns an empty list on encoding/decoding failure. - Update the test plan to account for the new assertions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/Net/OpenSSH.pm | Guard list-context capture against undef output by returning an empty list before splitting. |
| t/1_run.t | Add regression coverage for “bad encoding” in list-context capture, and update planned test count. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid splitting undefined output in list-context
captureafter_io3errors.Changes
_io3returned undef output.capture.Fixes #43.
Testing
perl -Ilib -c lib/Net/OpenSSH.pmperl -Ilib t/1_run.t