Use temporary files in integration test - #62
Open
salva wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the t/1_run.t integration test to generate its test artifacts in a temporary directory instead of the repository root, addressing issue #50 and keeping working trees clean after test runs.
Changes:
- Create a temp directory via
File::Temp::tempdirfor all generated test files. - Use shell-quoted temp paths for remote command invocations.
- Use unquoted local filesystem paths for
stdout_file,-fchecks, andunlink.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -155,30 +162,30 @@ ok(close $in); | |||
| @ps = `$PS_P $pid`; | |||
| ok(!grep(/ssh/i, @ps), "pipe_in SSH proccess is reaped on close"); | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop
t/1_run.tfrom writing generated test files into the repository root.Changes
File::Tempfor generated test data.stdout_file,-f, andunlinkoperations.Fixes #50.
Testing
perl -Ilib -c t/1_run.tperl -Ilib t/1_run.t