Add option to show at anchor location.#28
Open
geftimov wants to merge 5 commits into
Open
Conversation
Goooler
reviewed
Jul 12, 2022
Contributor
|
@saket CC |
Goooler
reviewed
Jul 12, 2022
Author
|
Hey @saket , do you think it would be possible to merge this? |
Goooler
reviewed
Sep 14, 2022
| } | ||
|
|
||
| private fun showCascadeMenu(anchor: View) { | ||
| private fun showCascadeMenu(anchor: View, showAtLocation: Boolean) { |
Contributor
There was a problem hiding this comment.
Suggested change
| private fun showCascadeMenu(anchor: View, showAtLocation: Boolean) { | |
| private fun showCascadeMenu(anchor: View, fromAnchor: Boolean) { |
|
why not merge？what are @saket doing |
Contributor
|
@saket Can we merge this? It would be very useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @saket,
first of all great library.
This is my take on "fixing" #21 and #26
This PR is for you to have a look at a potential solution.
Showing at location is trying always fit the popup in the current window.
ezgif.com-gif-maker.mp4