Feature/docker - #36
Merged
Merged
Conversation
Collaborator
There was a problem hiding this comment.
-
The Docker image can still be published even if the main test workflow fails, so it does not fully guarantee “publish only healthy code.”
-
The workflow builds the image but never runs the container in CI, so we are not checking that the demo actually starts correctly.
-
This branch removes the SonarQube setup already present on main Again :)
Owner
Author
|
you're right, my bad oop.... omw to fix it |
Owner
Author
|
see if everything is olrite |
- Added constants: RESULT_FORMAT, RESULT_LABEL, SHAPE_FORMAT - Added logShape() helper with conditional logging check - Added isInfoEnabled() guard in printMatrix() for conditional method invocation
… shush sonarqube)
Owner
Author
|
@YassineSamirX ready to merge imo! |
YassineSamirX
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All done! :)