Skip to content

Feature/maven dist - #35

Merged
YassineSamirX merged 7 commits into
mainfrom
feature/maven-dist
Apr 4, 2026
Merged

Feature/maven dist#35
YassineSamirX merged 7 commits into
mainfrom
feature/maven-dist

Conversation

@sMouaad

@sMouaad sMouaad commented Apr 4, 2026

Copy link
Copy Markdown
Owner

Build and publish SNAPSHOT versions automatically when code is updated and tests pass.

@sMouaad
sMouaad requested a review from YassineSamirX April 4, 2026 16:25
@sMouaad sMouaad linked an issue Apr 4, 2026 that may be closed by this pull request

@YassineSamirX YassineSamirX left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The publish workflow is missing the Maven authentication setup for GitHub Packages. Right now it runs mvn deploy, but Maven still needs credentials linked to the github repository id from pom.xml. Just passing GITHUB_TOKEN in the environment is usually not enough, so this may fail when trying to actually publish the artifact.

  2. There is a regression of what I did for sonarqube in pom.xml and ci.yml please check that

  3. The issue says publishing should require a minimum coverage rule before release, but that part is not implemented yet. Tests are executed before publish, which is good, but there is no JaCoCo threshold configured to block publishing when coverage is too low. So the current PR only checks test success, not coverage quality.

@YassineSamirX YassineSamirX self-assigned this Apr 4, 2026
@sMouaad
sMouaad requested a review from YassineSamirX April 4, 2026 18:57
@YassineSamirX

Copy link
Copy Markdown
Collaborator

finally done (hopefully) !

@YassineSamirX
YassineSamirX merged commit d422145 into main Apr 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up Maven continuous delivery (SNAPSHOT)

3 participants