Count rejected Liftosaur history records on Swift - #1497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the skipped-record undercount documented in bhelm/noop#94.
Swift's
for caseloop silently omitted non-object history elements, so they never reached the skipped counter. The loop now visits every element, increments once when an element is not a dictionary, and leaves the existing malformed-object and valid-session paths unchanged. Android already has the intended behavior and remains the unchanged product control.Tests
skipped == 3result.e65b967dc296d09d5ea40776d7b21495b5b75c850917048e3f67091001187f1f).c7571fd020d6947594eb79198ba88ece7ab4648824c312e0bbee9e14f1150d97) exercised this exact named test: Swift focused 1/1 passed; Swift affected 28 tests passed; Swift full 241 tests passed with 1 skip. Kotlin focused aggregate 7 tests passed; affected 35 passed; full 4,157 passed with 6 skips and no failures/errors./root/whoop/validation/product-fixes-93-99-union-native/43-final-audit.txt(recorded 2026-08-20, exact union hash and named-test occurrence audit).