Skip to content

Fix lifting note title delimiter parity - #1494

Merged
ryanbr merged 1 commit into
ryanbr:mainfrom
bhelm:fix/issue-93-lifting-note-delimiter
Aug 21, 2026
Merged

Fix lifting note title delimiter parity#1494
ryanbr merged 1 commit into
ryanbr:mainfrom
bhelm:fix/issue-93-lifting-note-delimiter

Conversation

@bhelm

@bhelm bhelm commented Aug 20, 2026

Copy link
Copy Markdown

Summary

Fixes the cross-platform lifting-note title delimiter mismatch documented in bhelm/noop#93.

Swift formatted a titled volume-load note with - while Android used : . This changes only the Swift title prefix to : and keeps parsing, calculations, persistence, and untitled-note behavior unchanged.

Tests

  • Adds mirrored exact Swift/Kotlin assertions for titled, nil/null-title, and empty-title notes.
  • Fresh independent static review of the exact frozen union delta passed with no P0/P1 findings; this PR's frozen three-file patch is an exact reviewed constituent (patch SHA-256 5b5d1f86ca41f23b5aa5ca5a39587dad429a468daf84d5ccc24e6e86a7ac98c6).
  • Combined Native validation on the reviewed union (c7571fd020d6947594eb79198ba88ece7ab4648824c312e0bbee9e14f1150d97) exercised this exact named test: Swift focused 1/1 passed; Swift affected 28 tests passed; Swift full 241 tests passed with 1 skip. Kotlin focused aggregate 7 tests passed; affected 35 passed; full 4,157 passed with 6 skips and no failures/errors.
  • Evidence artifact: /root/whoop/validation/product-fixes-93-99-union-native/43-final-audit.txt (recorded 2026-08-20, exact union hash and named-test occurrence audit).

@ryanbr
ryanbr merged commit 557f3b4 into ryanbr:main Aug 21, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants