Repository navigation
fix(oidc): save providers with an empty dynamic redirect URI - #265
Merged
Merged
Conversation
1 task done
cxymds
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
OIDC providers using dynamic redirects can return
redirect_uri: null. Normalize this value to an empty form field so edits can be saved after each configuration reload. Handle validation exceptions through the save error handler so failures display feedback and restore the saving state.Type of Change
Testing
Seven regression tests mount the OIDC page and exercise saving, reloading, static redirect validation, validation/payload exceptions, and API failures. Five tests fail against the original code; all seven pass with this change. The full suite passes all 702 tests on Node 22.
Browser validation used the actual Console page with a mocked API. The original page throws
null.trimbefore sending a PUT. The fixed page completes PUT + GET and a second save after the API returnsnullagain. Static redirect validation, API failure feedback with preserved input, and saving at a 390px mobile viewport also pass.Checklist
Related Issues
Refs rustfs/rustfs#8489.
Screenshots (if applicable)
Desktop and mobile captures use the actual Console page with mocked API responses.
Mobile save
Additional Notes
Configuration changes take effect after a RustFS restart. Rollback: revert this commit.