-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add LINK_STATE_* definitions to NetBSD and OpenBSD. #4751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Some changes occurred in OpenBSD module cc @semarie |
semarie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. tests are passing on OpenBSD.
JohnTitor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you turn the doc comments into regular comments to match the others? Usually we don't add user-facing docs in this crate, instead preferring if the user refers to the manpages.
Also the comments should be permalinks, otherwise they'll wind up getting out of date. On the GH UI you can do this by clicking the triple dots in the top right then "copy permalink".
|
@pusateri gentle ping, just a few tiny updates and a rebase needed here :) |
Head branch was pushed to by a user without write access
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Sorry, somehow I wasn't getting notifications on this. I have updated the branch with the changes you ask for. |
tgross35
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please squash
Description
Add missing interface LINK_STATE_* definitions from sys/net/if.h
Sources
https://github.com/NetBSD/src/blob/54613ac4db31045d0ca58a7e2da7af005c6b5cd2/sys/net/if.h#L207
https://github.com/openbsd/src/blob/bac4ed8757bbe68d4cac117487958588ae27e7c2/sys/net/if.h#L135
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI