Skip to content

fix(specs): make shared MAX_SIGNERS checks type-safe#176

Merged
dkcumming merged 3 commits intoproofsfrom
jh/fix-max-signers-kaas
Mar 11, 2026
Merged

fix(specs): make shared MAX_SIGNERS checks type-safe#176
dkcumming merged 3 commits intoproofsfrom
jh/fix-max-signers-kaas

Conversation

@Stevengre
Copy link

@Stevengre Stevengre commented Mar 11, 2026

Summary

This PR fixes the shared multisig initialize specs so they keep using MAX_SIGNERS directly while type-checking in both inclusion contexts.

The root issue was that the shared spec is included by both spl-token and p-token, but MAX_SIGNERS does not have the same type in both paths. Replacing the old magic numbers with MAX_SIGNERS therefore introduced a type mismatch in the proof/runtime-verification path.

Testing

  • cargo +nightly-2025-02-16 clippy --manifest-path p-token/Cargo.toml -Zunstable-options --all-targets --all-features -- --deny=warnings --deny=clippy::arithmetic_side_effects
  • cargo +nightly-2025-02-16 check -p spl-token --features runtime-verification
  • GitHub Actions: Format & Lint p-token passed in run 22931335543

@Stevengre Stevengre force-pushed the jh/fix-max-signers-kaas branch from f0be61a to bcb17a5 Compare March 11, 2026 00:40
@Stevengre Stevengre marked this pull request as draft March 11, 2026 00:41
@Stevengre Stevengre changed the title fix(runtime-verification): align multisig max signers fix(specs): make shared MAX_SIGNERS checks type-safe Mar 11, 2026
@Stevengre Stevengre self-assigned this Mar 11, 2026
@Stevengre Stevengre requested review from dkcumming and mariaKt March 11, 2026 01:35
@Stevengre Stevengre marked this pull request as ready for review March 11, 2026 01:35
@dkcumming dkcumming merged commit 24f50e8 into proofs Mar 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants