fix(symbolic-spl): discharge AccountState discriminant branches#978
Draft
Stevengre wants to merge 2 commits intocodex/upstream-bootstrap-feature-ptokenfrom
Draft
Conversation
3f8f76e to
f3b895f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a self-contained
prove-rsreproducer forAccountStatebranch selection and discharges the symbolic discriminant guard by combining explicitAccountStatedomain constraints with a#lookupDiscrAux(... ) ==Int Cnormalization rule.Context
After the multisig proof profile moved to 3 signers, the next live frontier in
test_process_revoke_multisigsat onif account.state == AccountState::Frozen. The path constraint already chose a branch, but the<k>cell still carried#lookupDiscrAux(... variantIdx(?SplAccountState)) ==Int 2, so branch selection stayed pending on a syntactic mismatch.Red vs Green
Red:
spl-accountstate-discriminant-branch.rsreaches theAccountState::Frozencheck with a symbolic discriminant term.#lookupDiscrAux(...) ==Int 2shape.Green:
cheatcode_is_spl_accountnow states the explicit 3-variantAccountStatediscriminant domain.#lookupDiscrAux(DISCRS, IDX) ==Int DISCRis normalized toDISCR ==Int #lookupDiscrAux(DISCRS, IDX), which matches the branch-constraint shape and lets#selectBlockdischarge the guard.References
spl_token::state::AccountState