fix(symbolic-spl): align multisig cheatcode with 3-signer profile#977
Open
Stevengre wants to merge 2 commits intofeature/p-tokenfrom
Open
fix(symbolic-spl): align multisig cheatcode with 3-signer profile#977Stevengre wants to merge 2 commits intofeature/p-tokenfrom
Stevengre wants to merge 2 commits intofeature/p-tokenfrom
Conversation
Stevengre
changed the title
mariaKt
reviewed
Mar 10, 2026
| andBool 0 <=Int ?SplMultisigN andBool ?SplMultisigN <Int 256 | ||
| ensures 0 <=Int ?SplMultisigM andBool ?SplMultisigM <=Int 3 | ||
| andBool 0 <=Int ?SplMultisigN andBool ?SplMultisigN <=Int 3 | ||
| andBool #isSplPubkey(?SplSigner0) |
Collaborator
There was a problem hiding this comment.
How is this number related to the maximum signers? E.g., 355 was changed to 99 because LEN = 3+32*MAX_SIGNERS. What is the condition here?
mariaKt
reviewed
Mar 10, 2026
Collaborator
mariaKt
left a comment
mariaKt
left a comment
There was a problem hiding this comment.
Looks good. There is a single change I need a clarification about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns the symbolic SPL multisig model with the 3-signer proof profile used on
feature/p-token.symbolic/spl-token.mdand prove-rs side of the sameMAX_SIGNERS = 3proof-profile change tracked in Change the number of signers from 11 to 3 #982.