fix(rt-data): handle singleton-array projection traversal#976
Draft
fix(rt-data): handle singleton-array projection traversal#976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds singleton-array runtime projection support in
rt/data.mdand a minimalprove-rsreproducer for pointer-cast writes through*mut [u8; 1].Context
The runtime already had type/projection plumbing for
projectionElemSingletonArray, but write paths still had no#traverseProjectionrule for that projection. When a pointer is cast to a singleton array pointer and then written through, execution reaches#traverseProjection(..., projectionElemSingletonArray ...)and stops.Red vs Green
Red:
singleton-array-pointer-cast-fail.rsgot stuck at#traverseProjection(..., projectionElemSingletonArray .ProjectionElems, .Contexts).close_account_multisigthroughstd::ptr::write_volatile::<[u8; 32]>.Green:
#traverseProjectionwraps the value in a singleton array context.#buildUpdateunwraps that singleton array on the way back out.#projectionsForreconstructs the projection path correctly, so the reproducer now runs as the passing fixturesingleton-array-pointer-cast.rsand reaches#EndPrograminstead of stopping at projection traversal.References
std::ptr::write