Force charset to utf8mb4 and utf8mb4_unicode_ci charset/collation #173
Conversation
| adapter: trilogy | ||
| encoding: utf8mb4 # <-- forces UTF-8 everywhere | ||
| collation: utf8mb4_unicode_ci # <-- portable across MySQL 5.7/8.0 and MariaDB | ||
| pool: <%= ENV.fetch("RAILS_MAX_THREADS", 5) %> |
There was a problem hiding this comment.
I actually get slightly nervous about making the pool the same size as the rails thread count ... mostly as it's possible that the rails application logic can (potentially) throw things out to their own background threads ...
I'm not really sure just how much this matters, but it's own of those things that makes me :hmmm:
| url: <%= ENV.fetch("DATABASE_URL", "trilogy://root@localhost") %> | ||
| default: &default | ||
| adapter: trilogy | ||
| encoding: utf8mb4 # <-- forces UTF-8 everywhere |
| user: root | ||
| password: |
There was a problem hiding this comment.
These should either be overridable ... or we should have some documentation in here explicitly pointing towards setting the DATABASE_URL envvar to override with local config. Not everyone knows that's a thing.
|
This pull request has been inactive for 30 days. Please update it or let us know if it is still relevant. |
1 similar comment
|
This pull request has been inactive for 30 days. Please update it or let us know if it is still relevant. |
maebeale
force-pushed
the
jp/fix-mysql-utf8
branch
from
825cba3 to
210abe5
Compare
| stdin_open: true | ||
| restart: unless-stopped | ||
|
|
||
| vite: |
There was a problem hiding this comment.
@johnpaulashenfelter were you intending to delete this vite section? i can't tell if this is a regression from my rebase
No description provided.